W3C Final implementation #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* W3C Tracecontext * adding comments * addressing PR comments
Implement W3C tracestate
* Initial integration of W3C protocol for incoming request * refactoring header name * updating the verbosity level when correlation fails * Fix bugs in correlation found via tests, implement more unit tests and address partial PR comments * improve createOutboundTracestate() * create tracestate when header not available * fix test * enable outbout w3c * Refactering code to use Helper methods with TraceContext classes * fix tracestate integration, fix outbound tracestate injection, fix tests, propogate traceflags * add property to turn on W3C in springboot starter, remove debug logs * adopt internal storage of id's to legacy AI format for backport, update tests * address PR comments * Fix an incorrect assert * refactor resolveCorrelation() method to be more readable and debuggable * rename method names, create outbound traceparent for http if there is no incoming request too * fixing a bug in w3c config for agent * fix the dependency type name, fix target to be host+port | target
3 tasks
...ain/java/com/microsoft/applicationinsights/agent/internal/agent/HttpClientMethodVisitor.java
Show resolved
Hide resolved
Contributor
Author
|
E2E correlation works. W3CTestDotNetApp has W3C turned off and only emits request-ids. |
lmolkova
reviewed
Dec 14, 2018
...ain/java/com/microsoft/applicationinsights/internal/agent/CoreAgentNotificationsHandler.java
Outdated
Show resolved
Hide resolved
...java/com/microsoft/applicationinsights/web/internal/correlation/TraceContextCorrelation.java
Outdated
Show resolved
Hide resolved
...java/com/microsoft/applicationinsights/web/internal/correlation/TraceContextCorrelation.java
Show resolved
Hide resolved
Contributor
Author
|
@lmolkova thanks for your comments. I have address them. |
Contributor
Author
...om/microsoft/applicationinsights/agent/internal/config/AgentBuiltInConfigurationBuilder.java
Outdated
Show resolved
Hide resolved
agent/src/main/java/com/microsoft/applicationinsights/agent/internal/config/XmlParserUtils.java
Outdated
Show resolved
Hide resolved
...main/java/com/microsoft/applicationinsights/autoconfigure/ApplicationInsightsProperties.java
Outdated
Show resolved
Hide resolved
dhaval24
commented
Dec 14, 2018
...ain/java/com/microsoft/applicationinsights/internal/agent/CoreAgentNotificationsHandler.java
Outdated
Show resolved
Hide resolved
This was referenced Dec 16, 2018
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final W3C implementation
#775 #782 #776 #716
@lmolkova you can skip this review if you want as you already reviewed the old PR.
@littleaj can you take a brief overview?
Enable W3C:
Incoming Side -
J2EE Apps add the following to the
<TelemetryModules>tag inside ApplicationInsights.xmlSpringboot apps add the following property:
azure.application-insights.web.enable-W3C=trueazure.application-insights.web.enable-W3C-backcompat-mode=trueOutgoing Side -
Add the following to AI-Agent.xml
Note: Please note that Backward compatibility mode is enabled by default and the enableW3CBackCompat parameter is optional and should be used only when you want to turn it off.
Ideally this would be the case when all your services have been updated to newer version of SDKs supporting W3C protocol. It is highly recommended to move to newer version of SDKs with W3C support as soon as possible.
Please ensure that both incoming and outgoing configurations are exactly same, or else it's very likely that correlation won't work properly.
i.e W3C and bckportMode on on incoming side -> Then W3C and backport mode should on on outgoing side as well.
For significant contributions please make sure you have completed the following items: